Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#762 Fix Plugin Report and Success/Warning icons, counts #763

Merged
merged 1 commit into from
Oct 17, 2022
Merged

#762 Fix Plugin Report and Success/Warning icons, counts #763

merged 1 commit into from
Oct 17, 2022

Conversation

sultan
Copy link
Contributor

@sultan sultan commented Oct 15, 2022 •
edited
Loading

Fixed #762

image

@sultan sultan mentioned this pull request Oct 15, 2022
Closed
@sultan sultan changed the title Fix Plugin Report and Success/Warning icons, counts #762 Fix Plugin Report and Success/Warning icons, counts Oct 16, 2022
@sultan sultan force-pushed the renderStatRow branch 2 times, most recently from dd974f7 to dedc75e Compare October 16, 2022 13:01
@sultan sultan marked this pull request as draft October 16, 2022 13:07
@sultan sultan marked this pull request as ready for review October 16, 2022 13:18
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 16, 2022
@sultan
Copy link
Contributor Author

sultan commented Oct 17, 2022

i can rebase this branch to ease review or leave it be. @slawekjaranowski ?

@slawekjaranowski
Copy link
Member

@sultan I already rebased with the latest master and squash to final commit yesterday

@sultan sultan marked this pull request as draft October 17, 2022 09:37
@sultan sultan marked this pull request as ready for review October 17, 2022 09:38
@sultan
Copy link
Contributor Author

sultan commented Oct 17, 2022

just to be sure we are on the same page,

  • this pr includes changes in 3 files that are not yet merged into main.
  • is ready/ can be marged

@slawekjaranowski
Copy link
Member

just to be sure we are on the same page,

  • this pr includes changes in 3 files that are not yet merged into main.

which files are not merged? ... I don't see

  • is ready/ can be marged

@sultan
Copy link
Contributor Author

sultan commented Oct 17, 2022 •
edited
Loading

src/main/java/org/codehaus/mojo/versions/reporting/

  • AbstractVersionsReportRenderer.java
  • PluginUpdatesReportRenderer.java
  • VersionsReportRendererBase.java

they should be visible via last rebase now

@slawekjaranowski slawekjaranowski merged commit 47ff2e7 into mojohaus:master Oct 17, 2022
@sultan sultan deleted the renderStatRow branch October 18, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Plugin Report table and icons broken
2 participants
@sultan @slawekjaranowski